[FFmpeg-soc] [soc]: r3964 - in wmapro: wma3.h wma3data.h?wma3dec.c

[Diego Biurrun]

On Sun, Jan 25, 2009 at 12:04:52AM +0100, Michael Niedermayer wrote:
> On Sat, Jan 24, 2009 at 07:05:47PM +0100, Diego Biurrun wrote:
> > On Sat, Jan 24, 2009 at 06:47:16PM +0100, Sascha Sommer wrote:
> > > 
> > > On Samstag, 17. Januar 2009, Diego Biurrun wrote:
> > > > On Sat, Jan 17, 2009 at 12:56:08PM -0800, Baptiste Coudurier wrote:
> > > > > faust3 wrote:
> > > > > > [...]
> > > > > >
> > > > > >          if ( idx == 126 )
> > > > > >          {
> > > > > >            while(i < 4){
> > > > >
> > > > > You may need to uniformize '{' placement, also get rid of these spaces
> > > > > before and after parentheses.
> > > >
> > > > I would suggest K&R style, which has spaces after if/while:
> > > >
> > > >     if (idx == 126) {
> > > >         while (i < 4) {
> > > 
> > > I prefere them without spaces.
> > > Anyway I'll try to fix this before I submit the first patch.
> > 
> > I suggest leaving personal preference aside in favor of a generally
> > consistent coding style across the project.
> 
> And id like to say that this is misordering priorities
> A common style is a good thing, raising very small fineprint like these
> spaces up to a strict rule is not.

I never said anything like what you imply.

Diego