[FFmpeg-soc] [soc]: r3964 - in wmapro: wma3.h wma3data.h?wma3dec.c

[Michael Niedermayer]

On Sat, Jan 24, 2009 at 07:05:47PM +0100, Diego Biurrun wrote:
> On Sat, Jan 24, 2009 at 06:47:16PM +0100, Sascha Sommer wrote:
> > 
> > On Samstag, 17. Januar 2009, Diego Biurrun wrote:
> > > On Sat, Jan 17, 2009 at 12:56:08PM -0800, Baptiste Coudurier wrote:
> > > > faust3 wrote:
> > > > > [...]
> > > > >
> > > > >          if ( idx == 126 )
> > > > >          {
> > > > >            while(i < 4){
> > > >
> > > > You may need to uniformize '{' placement, also get rid of these spaces
> > > > before and after parentheses.
> > >
> > > I would suggest K&R style, which has spaces after if/while:
> > >
> > >     if (idx == 126) {
> > >         while (i < 4) {
> > 
> > I prefere them without spaces.
> > Anyway I'll try to fix this before I submit the first patch.
> 
> I suggest leaving personal preference aside in favor of a generally
> consistent coding style across the project.

And id like to say that this is misordering priorities
A common style is a good thing, raising very small fineprint like these
spaces up to a strict rule is not. And i dont think K&R themselfs ever
advocated such asshatry.
ffmpeg is supposed to be fun to work on and forcing people to follow
some style where it is not helping readability is simply introducing
rules that have no justification.
A common indention width & tab vs. spaces as well as placing {} on the
same or next line are things that affect readability IMHO but a spaces
after if/while before { do not IMO.

And my oppinion is that the developers personal preferance should not
be messed with unless there is a real
quality/maintainabilty/simplicity/performance issue behind.

Basically there should be as few rules as possible, not as many as you
can come up with for the sake of universal consistency, we arent lawyers
but developers. I dont even know what K&R rules exactly mandate at such
fine level as you arue at here, and if even i dont, i think it really is
not reasonable to burden everyone with such fineprint.

PS: and yes i do ask people to fix minor style issues often, but i never
do once someone says he prefers a different style like keeping a few ()
or == 0 like you did here.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20090125/5f2e3fed/attachment.pgp>