[FFmpeg-soc] [soc]: r1341 - in eac3: eac3.h eac3dec.c

[Diego Biurrun]

On Thu, Sep 13, 2007 at 12:05:01PM +0200, Michael Niedermayer wrote:
> 
> On Thu, Sep 13, 2007 at 10:44:32AM +0200, Diego Biurrun wrote:
> > On Wed, Sep 12, 2007 at 11:25:16PM -0400, Justin Ruggles wrote:
> > > Diego Biurrun wrote:
> > > > On Wed, Sep 12, 2007 at 09:53:51AM +0200, bwolowiec wrote:
> > > >> @@ -1051,7 +1051,7 @@ static int parse_audblk(GetBitContext *g
> > > >> -    for(ch=!s->cplinu[blk]; ch<=s->ntchans; ch++){
> > > >> +    for(ch=!s->cplinu[blk]; ch<=s->num_channels; ch++){
> > > >>          if(s->chexpstr[blk][ch]!=EXP_REUSE){
> > > > 
> > > > Note that "for (" and "if (" is preferred.
> > > 
> > > For as long as I've been a part of FFmpeg, there has never been any 
> > > focus on small stylistic differences such as these, only on consistency. 
> > >   I personally don't use spaces between my for's/if's/while's and the 
> > > parentheses.  Nobody has ever called me out for it or suggested I change 
> > > my coding style.
> > 
> > Consistency is more important, true.  Nevertheless, if you look at some
> > of Michael's recent reviews, you will notice that the spaced forms are
> > indeed preferred.
> > 
> > Also, this code was mixing both forms.
> 
> i never complained about the lack of space, only about it being inconsistent
> 
> personally i normally write
> for(i=0; i<X; i++){
> }
> 
> grep 'for(i=' snow.c |wc
> 54     170    1747
> 
> grep 'for *( *i *=' snow.c | grep -v 'for(i='|wc
> 5      44     195

You are inconsistent ;-p

I thought you preferred the spaced form.  I personally prefer spaces,
but don't mind either way.  It should be consistent, though.

Diego