[FFmpeg-soc] EAC3 review

[Diego Biurrun]

On Mon, Sep 10, 2007 at 01:03:15PM -0700, Mike Melanson wrote:
> Michael Niedermayer wrote:
> > this is copy and pasted 1:1 from the pseudo code in the a52b spec
> > even the comments, and i suspect that applies to other parts as well
> > in principle that should be ok but well IANAL, diego whats your
> > oppinion about it? is it ok to copy and paste code from the spec?
> > or would it be better if we didnt do that, and what about the variable
> > names, they are practically all copy and pasted from the spec
> 
> I had a similar issue while creating a new VP3 decoder for lavc. For
> certain tasks, there just was not any other way to do something than the
> algorithm that already existed. I did not want to copy directly due to
> licensing confusion.
> 
> In those cases, I would at least rename the variables. :)

I agree with Mike, if there is only one possible algorithm then it
should be OK to copy it, but changing the variable names is good
nonetheless.

In any case, there is no excuse for bad variable names IMO.  Adding the
equivalent names from the spec in a comment should be a good compromise.

Diego