[FFmpeg-soc] [soc]: r465 - in qcelp: doc/TODO qcelpdata.h qcelpdec.c

[Michael Niedermayer]

Hi

On Tue, Jul 17, 2007 at 09:39:21PM +0200, reynaldo wrote:
> Author: reynaldo
> Date: Tue Jul 17 21:39:21 2007
> New Revision: 465
> 
> Log:
> - Implemented pitch synthesis filter
[...]
> Modified: qcelp/qcelpdata.h
> ==============================================================================
> --- qcelp/qcelpdata.h	(original)
> +++ qcelp/qcelpdata.h	Tue Jul 17 21:39:21 2007
> @@ -25,6 +25,9 @@
>   */
>  
>  #define FXQ(v)  (roundf(16384.0*v)/16384.0)
> +#ifndef PI
> +#define PI 3.141592653
> +#endif

common.h gurantees existence of a M_PI


[...]
>      if(!is_ifq)
>      {
>          qcelp_compute_svector(q->frame->rate, gain, index, cbseed, cdn_vector);
> +        if(is_ifq = qcelp_do_pitchfilter(q->frame, cdn_vector))
> +        {
> +            av_log(NULL, AV_LOG_ERROR, "Error can't pitch cdn_vector[%d]\n",
> +            is_ifq);

please provide av_log() with a non null context

also

av_log(NULL, AV_LOG_ERROR, "Error can't pitch cdn_vector[%d]\n",
       is_ifq);

or

av_log(NULL, 
       AV_LOG_ERROR, 
       "Error can't pitch cdn_vector[%d]\n",
       is_ifq);

is more readable if you cant put it all on one line

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070717/bdf7a3b9/attachment.pgp>