[FFmpeg-soc] [soc]: r465 - in qcelp: doc/TODO qcelpdata.h qcelpdec.c

[Reynaldo Verdejo]

Hi

On 7/17/07, Michael Niedermayer <michaelni at gmx.at> wrote:

> >  #define FXQ(v)  (roundf(16384.0*v)/16384.0)
> > +#ifndef PI
> > +#define PI 3.141592653
> > +#endif
>
> common.h gurantees existence of a M_PI


Fixed already, thanks.

> +        {
> > +            av_log(NULL, AV_LOG_ERROR, "Error can't pitch
> cdn_vector[%d]\n",
> > +            is_ifq);
>
> please provide av_log() with a non null context



Sure,  consider those msgs just placeholders by now, I'm going to rework and
fix most of them while working on the decoder glue-code, I'll keep this in
mind.

also
>
> av_log(NULL, AV_LOG_ERROR, "Error can't pitch cdn_vector[%d]\n",
>        is_ifq);
>
> or
>
> av_log(NULL,
>        AV_LOG_ERROR,
>        "Error can't pitch cdn_vector[%d]\n",
>        is_ifq);
>
> is more readable if you cant put it all on one line


Ok, will fix. Sometimes I go too far with my wrapalergy :)

Thanks for your comments.

Reynaldo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070717/c79c2e7e/attachment.htm>