[FFmpeg-soc] [soc]: r310 - in qcelp: README doc doc/NOTES doc/TODO qcelp.h qcelp_glue.diff qcelpdec.c srcprepare.sh

[Reynaldo Verdejo]

On 7/4/07, Diego Biurrun <diego at biurrun.de> wrote:
>
> On Tue, Jul 03, 2007 at 10:16:49PM +0200, reynaldo wrote:
> >
> > Log:
> > Some structural code frame, only thing I would consider ready for
> initial peer review here is the parsing and reordering routine. feel free to
> destroy everything along with it thouhg ;)
>
> Huh, that's long, did your enter key break? ;-p


-m"...", never used the  $EDITOR for commint messages, maybe I should.

Below are some nits I noticed while reading through the code.


I was specting this ;)

> +++ qcelp/qcelp.h     Tue Jul  3 22:16:49 2007
>
> Why not call this file qcelpdec.h?


I will.

> + * YOU WONT SEE ANY mention of a REFERENCE nor an UNIVERSAL frame
>
> Your keyboard seems to have the same problem as Michael's, stuck ' key.


I will keep avoiding the ' then, there must be a good reason to leave it
out, we just
don't see it. :)

> + * QCELPBitmap showing the location of each bit in the input * with
> > + * respect to a transmision code in the 'universal frame'.
>
> transmission
>
> I don't understand this sentence.  What does the * mean?


Nothing, it was a typo.

> + * it would be really nice if someone reviewed this numbers :)
>
> these


What about the numbers? :-)

> + * Oce frame is parsed all data gets stored in QCELPFrame.data acording
> > + * to this structure:
>
> Once the frame?


Yup.

> +typedef struct {
> > +    GetBitContext gb;
> > +    QCELPFrame    *frame;
> > +    uint8_t       erasure_count;
>
> This variable name is not very good.  What is it supposed to represent?


believe it or not I think Its the best name for it, you can look 'erasure'
up in the spec.

> +    /* particularities for rate 1/8 */
>
> I think you mean "peculiarities" here if you are talking about special
> cases.
> The English word "particularity" is close to "precisión" in Spanish.


Thanks, didn't knew that.

Best regards

   Reynaldo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20070704/c9ff330f/attachment.htm>