On 7/4/07, <b class="gmail_sendername">Diego Biurrun</b> <<a href="mailto:diego@biurrun.de">diego@biurrun.de</a>> wrote:<div><span class="gmail_quote"></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
On Tue, Jul 03, 2007 at 10:16:49PM +0200, reynaldo wrote:<br>><br>> Log:<br>> Some structural code frame, only thing I would consider ready for initial peer review here is the parsing and reordering routine. feel free to destroy everything along with it thouhg ;)
<br><br>Huh, that's long, did your enter key break? ;-p</blockquote><div><br>-m"...", never used the $EDITOR for commint messages, maybe I should.<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Below are some nits I noticed while reading through the code.</blockquote><div><br>I was specting this ;) <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> +++ qcelp/qcelp.h Tue Jul 3 22:16:49 2007<br><br>Why not call this file qcelpdec.h?</blockquote><div><br>I will. <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> + * YOU WONT SEE ANY mention of a REFERENCE nor an UNIVERSAL frame<br><br>Your keyboard seems to have the same problem as Michael's, stuck ' key.</blockquote><div><br>I will keep avoiding the ' then, there must be a good reason to leave it out, we just
<br>don't see it. :)<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> + * QCELPBitmap showing the location of each bit in the input * with
<br>> + * respect to a transmision code in the 'universal frame'.<br><br>transmission<br><br>I don't understand this sentence. What does the * mean?</blockquote><div><br>Nothing, it was a typo.<br></div><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> + * it would be really nice if someone reviewed this numbers :)<br><br>these</blockquote>
<div><br>What about the numbers? :-) <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> + * Oce frame is parsed all data gets stored in
QCELPFrame.data acording<br>> + * to this structure:<br><br>Once the frame?</blockquote><div><br>Yup. <br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> +typedef struct {<br>> + GetBitContext gb;<br>> + QCELPFrame *frame;<br>> + uint8_t erasure_count;<br><br>This variable name is not very good. What is it supposed to represent?</blockquote>
<div><br>believe it or not I think Its the best name for it, you can look 'erasure' up in the spec.<br></div><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
> + /* particularities for rate 1/8 */<br><br>I think you mean "peculiarities" here if you are talking about special cases.<br>The English word "particularity" is close to "precisión" in Spanish.
</blockquote><div><br>Thanks, didn't knew that.<br><br>Best regards<br><br> Reynaldo<br></div></div><br>