[FFmpeg-soc] [soc]: r1173 - dvbmuxer/mpeg_pes_enc.c
realsun
sunxiaohui at dsp.ac.cn
Mon Aug 27 16:16:26 CEST 2007
Baptiste Coudurier wrote:
> Hi
>
> realsun wrote:
>
>> Author: realsun
>> Date: Fri Aug 24 03:05:45 2007
>> New Revision: 1173
>>
>> Log:
>> Cosmetics: add comments
>>
>> Modified:
>> dvbmuxer/mpeg_pes_enc.c
>>
>> Modified: dvbmuxer/mpeg_pes_enc.c
>> ==============================================================================
>> --- dvbmuxer/mpeg_pes_enc.c (original)
>> +++ dvbmuxer/mpeg_pes_enc.c Fri Aug 24 03:05:45 2007
>>
>> [...]
>>
>> +/**
>> + * Get total number of frames that have been muxed.
>> + * @param[in] ctx the AVFormatContext
>> + * @param[in] stream the PES stream
>> + * @param[in] len PES packet size
>> + * @return the frame number to be muxed
>> + */
>>
>
> There is an ambiguity between function description and return value
> description.
>
fixed
>
>> int ff_get_nb_frames(AVFormatContext *ctx, PESStream *stream, int len){
>>
>
> Change function name to match function description, also put ff_pes in name.
>
>
fixed
>> int nb_frames=0;
>> PacketDesc *pkt_desc= stream->premux_packet;
>> @@ -89,6 +101,21 @@ int ff_get_nb_frames(AVFormatContext *ct
>> return nb_frames;
>> }
>>
>> +/**
>> + * Mux streams into a PES packet.
>>
>
> Description is not precise enough. Elaborate.
>
I have changed to "Mux one stream into PES stream"
> [...]
>
>
More information about the FFmpeg-soc
mailing list