[FFmpeg-soc] [soc]: r1173 - dvbmuxer/mpeg_pes_enc.c

Baptiste Coudurier baptiste.coudurier at smartjog.com
Mon Aug 27 11:28:27 CEST 2007


Hi

realsun wrote:
> Author: realsun
> Date: Fri Aug 24 03:05:45 2007
> New Revision: 1173
> 
> Log:
> Cosmetics: add comments
> 
> Modified:
>    dvbmuxer/mpeg_pes_enc.c
> 
> Modified: dvbmuxer/mpeg_pes_enc.c
> ==============================================================================
> --- dvbmuxer/mpeg_pes_enc.c	(original)
> +++ dvbmuxer/mpeg_pes_enc.c	Fri Aug 24 03:05:45 2007
>
> [...]
>  
> +/**
> + * Get total number of frames that have been muxed.
> + * @param[in] ctx    the AVFormatContext
> + * @param[in] stream the PES stream
> + * @param[in] len    PES packet size
> + * @return  the frame number to be muxed
> + */

There is an ambiguity between function description and return value
description.

>  int ff_get_nb_frames(AVFormatContext *ctx, PESStream *stream, int len){

Change function name to match function description, also put ff_pes in name.

>      int nb_frames=0;
>      PacketDesc *pkt_desc= stream->premux_packet;
> @@ -89,6 +101,21 @@ int ff_get_nb_frames(AVFormatContext *ct
>      return nb_frames;
>  }
>  
> +/**
> + * Mux streams into a PES packet.

Description is not precise enough. Elaborate.

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312



More information about the FFmpeg-soc mailing list