[FFmpeg-soc] [soc]: r908 - eac3/eac3_parser.c

[Bartlomiej Wolowiec]

On Friday 17 August 2007 19:30, Diego Biurrun wrote:
> On Fri, Aug 17, 2007 at 02:13:05PM +0200, bwolowiec wrote:
> > Log:
> > cosmetics
>
> These are most definitely *NOT* cosmetics.  Cosmetic changes are changes
> to comments or whitespace changes or variable renamings or similar
> things that do not result in a different object file.  Replacing a
> constant by a macro is not a cosmetic change.
>
> You should update the log message to reflect what you really did.  Also,
> this commit mixes several independent and unrelated changes and should
> thus have been split.

Hi,
I changed log message, you're right, it wasn't "cosmetics". Next time I'll try 
to decribe the changes more appropriately and do not include many changes in 
one commit.