[FFmpeg-soc] [soc]: r908 - eac3/eac3_parser.c

Diego Biurrun diego at biurrun.de
Fri Aug 17 19:30:09 CEST 2007


On Fri, Aug 17, 2007 at 02:13:05PM +0200, bwolowiec wrote:
> 
> Log:
> cosmetics

These are most definitely *NOT* cosmetics.  Cosmetic changes are changes
to comments or whitespace changes or variable renamings or similar
things that do not result in a different object file.  Replacing a
constant by a macro is not a cosmetic change.

You should update the log message to reflect what you really did.  Also,
this commit mixes several independent and unrelated changes and should
thus have been split.

Diego



More information about the FFmpeg-soc mailing list