[FFmpeg-soc] [soc]: r632 - in eac3: ac3.c ac3.h ac3tab.c ac3tab.h eac3.h eac3_parser.c eac3dec.c

[Diego Biurrun]

On Wed, Aug 08, 2007 at 04:54:38PM +0200, bwolowiec wrote:
> 
> Log:
> Channel Coupling
> 
> --- eac3/ac3.c	(original)
> +++ eac3/ac3.c	Wed Aug  8 16:54:38 2007
> @@ -489,7 +489,7 @@ static void apply_dithering(int nchans, 
>  
> -void ff_ac3_get_transform_coeffs(GetBitContext *gb, uint8_t (*bap)[AC3_MAX_COEFS], uint8_t (*dexps)[AC3_MAX_COEFS], int nchans, int *chincpl, int *dithflag, float (*transform_coeffs)[AC3_MAX_COEFS], int *strtmant, int *endmant, AVRandomState *dith_state)
> +void ff_ac3_get_transform_coeffs(GetBitContext *gb, uint8_t (*bap)[AC3_MAX_COEFS], uint8_t (*dexps)[AC3_MAX_COEFS], int nchans, int *chincpl, int *dithflag, float (*transform_coeffs)[AC3_MAX_COEFS], int *strtmant, int *endmant, AVRandomState *dith_state, int ncplbnd, int *cplbndstrc, float (*cplco)[18])

These are a lot of parameters...

> --- eac3/eac3_parser.c	(original)
> +++ eac3/eac3_parser.c	Wed Aug  8 16:54:38 2007
> @@ -19,16 +19,18 @@
>  #ifdef DEBUG
> -#define GET_BITS(a, gbc, n) a = get_bits(gbc, n); av_log(NULL, AV_LOG_INFO, "%s: %i\n", __STRING(a), a)
> -#define GET_SBITS(a, gbc, n) a = get_sbits(gbc, n); av_log(NULL, AV_LOG_INFO, "%s: %i\n", __STRING(a), a)
> +#define GET_BITS(a, gbc, n) {a = get_bits(gbc, n); av_log(NULL, AV_LOG_INFO, "%s: %i\n", __STRING(a), a);}
> +#define GET_SBITS(a, gbc, n) {a = get_sbits(gbc, n); av_log(NULL, AV_LOG_INFO, "%s: %i\n", __STRING(a), a);}

This could be vertically aligned.

>  #else
>  #define GET_BITS(a, gbc, n) a = get_bits(gbc, n)
>  #define GET_SBITS(a, gbc, n) a = get_sbits(gbc, n)

same here

> @@ -503,6 +504,7 @@ int ff_eac3_parse_audblk(GetBitContext *
>      }
> +    s->dithflag[CPL_CH] = s->dithflag[s->lfe_channel] = 0;
>      /* These fields for dynamic range control */

These fields "are" for dynamic range control?

> @@ -1133,6 +1155,13 @@ int ff_eac3_parse_audblk(GetBitContext *
>  
>      /* These fields for inclusion of unused dummy data */

Same here, "are for"?

> @@ -1199,7 +1227,7 @@ int ff_eac3_parse_audblk(GetBitContext *
>      /* These fields for quantized mantissa values */

and here

Please don't leave the verbs out of your sentences, it's a sure way to
make them impossible to understand.

Diego