[FFmpeg-soc] [soc]: r632 - in eac3: ac3.c ac3.h ac3tab.c ac3tab.h eac3.h eac3_parser.c eac3dec.c

[Bartlomiej Wolowiec]

On Wednesday 08 August 2007 20:30, Diego Biurrun wrote:
> On Wed, Aug 08, 2007 at 04:54:38PM +0200, bwolowiec wrote:
> > Log:
> > Channel Coupling
> >
> > --- eac3/ac3.c	(original)
> > +++ eac3/ac3.c	Wed Aug  8 16:54:38 2007
> > @@ -489,7 +489,7 @@ static void apply_dithering(int nchans,
> >
> > -void ff_ac3_get_transform_coeffs(GetBitContext *gb, uint8_t
> > (*bap)[AC3_MAX_COEFS], uint8_t (*dexps)[AC3_MAX_COEFS], int nchans, int
> > *chincpl, int *dithflag, float (*transform_coeffs)[AC3_MAX_COEFS], int
> > *strtmant, int *endmant, AVRandomState *dith_state) +void
> > ff_ac3_get_transform_coeffs(GetBitContext *gb, uint8_t
> > (*bap)[AC3_MAX_COEFS], uint8_t (*dexps)[AC3_MAX_COEFS], int nchans, int
> > *chincpl, int *dithflag, float (*transform_coeffs)[AC3_MAX_COEFS], int
> > *strtmant, int *endmant, AVRandomState *dith_state, int ncplbnd, int
> > *cplbndstrc, float (*cplco)[18])
>
> These are a lot of parameters...
>
> > --- eac3/eac3_parser.c	(original)
> > +++ eac3/eac3_parser.c	Wed Aug  8 16:54:38 2007
> > @@ -19,16 +19,18 @@
> >  #ifdef DEBUG
> > -#define GET_BITS(a, gbc, n) a = get_bits(gbc, n); av_log(NULL,
> > AV_LOG_INFO, "%s: %i\n", __STRING(a), a) -#define GET_SBITS(a, gbc, n) a
> > = get_sbits(gbc, n); av_log(NULL, AV_LOG_INFO, "%s: %i\n", __STRING(a),
> > a) +#define GET_BITS(a, gbc, n) {a = get_bits(gbc, n); av_log(NULL,
> > AV_LOG_INFO, "%s: %i\n", __STRING(a), a);} +#define GET_SBITS(a, gbc, n)
> > {a = get_sbits(gbc, n); av_log(NULL, AV_LOG_INFO, "%s: %i\n",
> > __STRING(a), a);}
>
> This could be vertically aligned.
>
> >  #else
> >  #define GET_BITS(a, gbc, n) a = get_bits(gbc, n)
> >  #define GET_SBITS(a, gbc, n) a = get_sbits(gbc, n)
>
> same here

the arguments of the function will be clustered in a structure. In the 
following days  I will try to adapt the code to the current ac3dec.c version 
and then  the code will be formatted and made clear.

>
> > @@ -503,6 +504,7 @@ int ff_eac3_parse_audblk(GetBitContext *
> >      }
> > +    s->dithflag[CPL_CH] = s->dithflag[s->lfe_channel] = 0;
> >      /* These fields for dynamic range control */
>
> These fields "are" for dynamic range control?
>
> > @@ -1133,6 +1155,13 @@ int ff_eac3_parse_audblk(GetBitContext *
> >
> >      /* These fields for inclusion of unused dummy data */
>
> Same here, "are for"?
>
> > @@ -1199,7 +1227,7 @@ int ff_eac3_parse_audblk(GetBitContext *
> >      /* These fields for quantized mantissa values */
>
> and here
Yes, I know, but some of the comments were copied with the pseudo code from 
original documentation... I will try to change most of them and add new ones. 
Some of my comments are now in a short form to remember that some things were 
to bo done in the nearest time...
-- 
Best Regards,
Bartlomiej Wolowiec