[FFmpeg-devel] When to add 'Reviewed-by: xxx' in commit messages

[softworkz .]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Marvin Scholz
> Sent: Dienstag, 27. Mai 2025 11:28
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] When to add 'Reviewed-by: xxx' in commit
> messages
> 
> 
> 
> On 3 May 2025, at 11:32, softworkz . wrote:
> 
> > Hello everybody,
> >
> > I have an organizational question that I cannot quite figure out how
> to do it right:
> >
> > Whether and when to add 'Reviewed-by:  xxx' to a commit message?
> >
> 
> Personally I try add this when someone reviewed and gave a LGTM
> for the patch as then I can be sure they (hopefully) actually
> reviewed the whole patch.
> 
> I sometimes comment on patches, that does not mean I reviewed
> those fully, just that I saw something that I felt worth to add
> a remark, I would not like to be added as Reviewed-by for that,
> as it would not be true.

Hi Marvin,

thanks a lot for the reply!

On Patchwork, there's the "A/L/R/T" column. AFAIK, the 

A (acked-by), R (reviewed-by) and T (tested-by) columns are detected
from lines in the commit message and L (LGTM) is based on detection
from response messages on the ML.

Side note: LGTM detection only seems to work when it's at the start 
           of a line.

Responses with LGTM have become a bit rare these days, that's what
is making the situation somewhat more unclear to me (and eventually
led me to ask about it).

On the other hand, what you are describing is a very clear and straight-
forward pattern and I will adhere to it in the future:

LGTM => reviewed-by <...> in the next revision

(unless others have additional thoughts to share and consider)

Thank you very much
sw