[FFmpeg-devel] When to add 'Reviewed-by: xxx' in commit messages

[Marvin Scholz]

On 3 May 2025, at 11:32, softworkz . wrote:

> Hello everybody,
>
> I have an organizational question that I cannot quite figure out how to do it right:
>
> Whether and when to add 'Reviewed-by:  xxx' to a commit message?
>

Personally I try add this when someone reviewed and gave a LGTM
for the patch as then I can be sure they (hopefully) actually
reviewed the whole patch.

I sometimes comment on patches, that does not mean I reviewed
those fully, just that I saw something that I felt worth to add
a remark, I would not like to be added as Reviewed-by for that,
as it would not be true.

> Specific example: The “execution graph printing” patchset:
>
> Andreas had reviewed the patchset initially. I addressed the mentioned
> issues. Is that the point to add 'Reviewed-by:’ already? And what about
> the commits without comments? Should I assume them to be reviewed
> as well? And how about later changes, do they invalidate it?
>
> From Stefano, I believe that he didn’t review the last two commits (due
> to being outside of the text formatting scope, I suppose). I added him
> as “reviewed by” only to those where he said “should be ok” or similar.
> Andreas didn’t say anything like that, yet I’m sure that he has carefully
> looked over everything.
>
> It might not be a big thing after all, but I don't want to be unjust to
> anybody and I'm unsure how to handle this, because I can imagine that
> someone might either say "Hey, why is he mentioning me, that's not the
> version that I have reviewed!" but also "Why doesn't he mention me, I've
> reviewed the whole thing in detail?".
> That's the circle by which I got trapped at the moment. 😉
>
> I'd be glad if somebody could provide me some guidance in this regard.
>
> Thanks a lot,
> sw
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".