[FFmpeg-devel] [PATCH] tests/fate/mov: Add bitexact for fate-mov-mp4-frag-flush

[Michael Niedermayer]

On Fri, Jun 06, 2025 at 12:52:33PM +0800, Zhao Zhili wrote:
> 
> 
> > On Jun 6, 2025, at 10:35, Michael Niedermayer <michael at niedermayer.cc> wrote:
> > 
> > On Fri, Jun 06, 2025 at 03:40:33AM +0200, Andreas Rheinhardt wrote:
> >> Michael Niedermayer:
> >>> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> >>> ---
> >>> tests/fate/mov.mak | 4 ++--
> >>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>> 
> >>> diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak
> >>> index b966249dc07..117d6581e9b 100644
> >>> --- a/tests/fate/mov.mak
> >>> +++ b/tests/fate/mov.mak
> >>> @@ -84,9 +84,9 @@ fate-mov-ibi-elst-starts-b: CMD = framemd5 -flags +bitexact -i $(TARGET_SAMPLES)
> >>> # Makes sure that we handle overlapping framgments
> >>> fate-mov-frag-overlap: CMD = framemd5 -i $(TARGET_SAMPLES)/mov/frag_overlap.mp4
> >>> 
> >>> -fate-mov-mp4-frag-flush: CMD = md5 -f lavfi -i color=blue,format=rgb24,trim=duration=0.04 -f lavfi -i anullsrc,aformat=s16,atrim=duration=2 -c:v png -c:a pcm_s16le -movflags +empty_moov+hybrid_fragmented -frag_duration 1000000 -frag_interleave 1 -f mp4
> >>> +fate-mov-mp4-frag-flush: CMD = md5 -f lavfi -i color=blue,format=rgb24,trim=duration=0.04 -f lavfi -i anullsrc,aformat=s16,atrim=duration=2 -c:v png -c:a pcm_s16le -movflags +empty_moov+hybrid_fragmented -frag_duration 1000000 -frag_interleave 1 -flags +bitexact -f mp4
> >>> fate-mov-mp4-frag-flush: CMP = oneline
> >>> -fate-mov-mp4-frag-flush: REF = a10c0e2e2dfc120f31ca5e59e0e4392a
> >>> +fate-mov-mp4-frag-flush: REF = b77ccd79e5455c6b7830e76fedf168f7
> >>> FATE_MOV_FFMPEG-$(call ALLYES, LAVFI_INDEV COLOR_FILTER FORMAT_FILTER TRIM_FILTER \
> >>>                                ANULLSRC_FILTER AFORMAT_FILTER ATRIM_FILTER        \
> >>>                                WRAPPED_AVFRAME_DECODER PCM_S16LE_DECODER PCM_S16BE_DECODER \
> >> 
> >> This removes the lavc version from the stream-level "encoder" tag, yet
> >> the lavf version is still kept in the format metadata. Use -bitexact to
> >> disable both (or -flags +bitexact -fflags +bitexact).
> > 
> > ok, will apply this tomorrow:
> > @@ -84,9 +84,9 @@ fate-mov-ibi-elst-starts-b: CMD = framemd5 -flags +bitexact -i $(TARGET_SAMPLES)
> > # Makes sure that we handle overlapping framgments
> > fate-mov-frag-overlap: CMD = framemd5 -i $(TARGET_SAMPLES)/mov/frag_overlap.mp4
> > 
> > -fate-mov-mp4-frag-flush: CMD = md5 -f lavfi -i color=blue,format=rgb24,trim=duration=0.04 -f lavfi -i anullsrc,aformat=s16,atrim=duration=2 -c:v png -c:a pcm_s16le -movflags +empty_moov+hybrid_fragmented -frag_duration 1000000 -frag_interleave 1 -f mp4
> > +fate-mov-mp4-frag-flush: CMD = md5 -f lavfi -i color=blue,format=rgb24,trim=duration=0.04 -f lavfi -i anullsrc,aformat=s16,atrim=duration=2 -c:v png -c:a pcm_s16le -movflags +empty_moov+hybrid_fragmented -frag_duration 1000000 -frag_interleave 1 -bitexact -f mp4
> > fate-mov-mp4-frag-flush: CMP = oneline
> > -fate-mov-mp4-frag-flush: REF = a10c0e2e2dfc120f31ca5e59e0e4392a
> > +fate-mov-mp4-frag-flush: REF = c9d0236bde4a0b24a01f6a032fd72e04
> > FATE_MOV_FFMPEG-$(call ALLYES, LAVFI_INDEV COLOR_FILTER FORMAT_FILTER TRIM_FILTER \
> >                                ANULLSRC_FILTER AFORMAT_FILTER ATRIM_FILTER        \
> >                                WRAPPED_AVFRAME_DECODER PCM_S16LE_DECODER PCM_S16BE_DECODER \
> 
> Thanks for the fix.
> 
> It’s easy to miss this or that with FATE, can we have a test for test, and recursively until the final reliable test :P

running fate with random offset added to versions could be done but it
would trigger full rebuild

maybe we could add bitexact in a more automated way in fate so its harder to forget

about the dependancies theres --enable-random and also a test on fate.ffmpeg.org with it

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

For a strong democracy, genuine criticism is necessary, allegations benefit
noone, they just cause unnecessary conflicts. - Narendra Modi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250606/e2b78f44/attachment.sig>