[FFmpeg-devel] [PATCH 1/2] avformat/whip: Remove unnecessary pkt checks

Steven Liu lq at chinaffmpeg.org
Fri Jun 6 06:02:05 EEST 2025


h264_annexb_insert_sps_pps (called after write_packet)
reorganizes PPS, SPS, and IDR packets in H.264 streams.
Since write_packet already validates pkt,
redundant null checks in h264_annexb_insert_sps_pps can be removed.

Signed-off-by: Steven Liu <lq at chinaffmpeg.org>
---
 libavformat/whip.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libavformat/whip.c b/libavformat/whip.c
index 0671e23635..ce06a66bc4 100644
--- a/libavformat/whip.c
+++ b/libavformat/whip.c
@@ -1660,8 +1660,6 @@ static int h264_annexb_insert_sps_pps(AVFormatContext *s, AVPacket *pkt)
     uint8_t unit_type, sps_seen = 0, pps_seen = 0, idr_seen = 0, *out;
     const uint8_t *buf, *buf_end, *r1;
 
-    if (!pkt || !pkt->data || pkt->size <= 0)
-        return ret;
     if (!par || !par->extradata || par->extradata_size <= 0)
         return ret;
 
-- 
2.39.3 (Apple Git-146)



More information about the ffmpeg-devel mailing list