[FFmpeg-devel] [PATCH] libavformat/matroskadec: Add support for chapter segment UUID and edition UID

[Alexander bladh]

Sorry, must have messed something up when running the tests locally.
I will also check the warning.

New contributor here, I have been looking at this issue for years now so I
thought I would try to contribute.
https://trac.ffmpeg.org/ticket/3123

My plan is
* Read the extra data needed to support ordered chapters
* Add some data structure tracking external files
* Add an option to search for external segment with related discovery logic
* Implement reading and seeking through external segments

Let me know if you have any feedback.

Regards,
Alexander

On Sat, 5 Apr 2025 at 01:37, Michael Niedermayer <michael at niedermayer.cc>
wrote:

> On Fri, Apr 04, 2025 at 11:24:05AM +0200, Alexander Westberg-Bladh wrote:
> > This adds support for parsing ChapterSegmentUID and
> ChapterSegmentEditionUID
> > elements in Matroska chapters. These elements are used in ordered
> chapters
> > to reference external files see #3123.
> >
> > Signed-off-by: Alexander Westberg-Bladh <alexander.bladh at gmail.com>
> > ---
> >  libavformat/matroska.h    |  3 +++
> >  libavformat/matroskadec.c | 32 ++++++++++++++++++++------------
> >  2 files changed, 23 insertions(+), 12 deletions(-)
>
> breaks fate-h264-direct-bff
>
> ==3402053== Invalid read of size 8
> ==3402053==    at 0x126DCE6: av_buffer_realloc (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x67E927: ebml_parse (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x67EC84: ebml_parse (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x67EC84: ebml_parse (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x67F421: matroska_read_header (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x625A1E: avformat_open_input (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x3054D4: ifile_open (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x31C417: open_files.isra.0 (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x31E3F5: ffmpeg_parse_options (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x2FCD77: main (in ffmpeg/ffmpeg_g)
> ==3402053==  Address 0x118dd288 is 0 bytes after a block of size 1,672
> alloc'd
> ==3402053==    at 0x483E0F0: memalign (in
> /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==3402053==    by 0x483E212: posix_memalign (in
> /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==3402053==    by 0x128A524: av_malloc (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x128A6ED: av_mallocz (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x625DC4: avformat_open_input (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x3054D4: ifile_open (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x31C417: open_files.isra.0 (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x31E3F5: ffmpeg_parse_options (in ffmpeg/ffmpeg_g)
> ==3402053==    by 0x2FCD77: main (in ffmpeg/ffmpeg_g)
>
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> No great genius has ever existed without some touch of madness. --
> Aristotle
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>