[FFmpeg-devel] [PATCH] libavformat/matroskadec: Add support for chapter segment UUID and edition UID

[Michael Niedermayer]

On Fri, Apr 04, 2025 at 11:24:05AM +0200, Alexander Westberg-Bladh wrote:
> This adds support for parsing ChapterSegmentUID and ChapterSegmentEditionUID
> elements in Matroska chapters. These elements are used in ordered chapters
> to reference external files see #3123.
> 
> Signed-off-by: Alexander Westberg-Bladh <alexander.bladh at gmail.com>
> ---
>  libavformat/matroska.h    |  3 +++
>  libavformat/matroskadec.c | 32 ++++++++++++++++++++------------
>  2 files changed, 23 insertions(+), 12 deletions(-)

breaks fate-h264-direct-bff

==3402053== Invalid read of size 8
==3402053==    at 0x126DCE6: av_buffer_realloc (in ffmpeg/ffmpeg_g)
==3402053==    by 0x67E927: ebml_parse (in ffmpeg/ffmpeg_g)
==3402053==    by 0x67EC84: ebml_parse (in ffmpeg/ffmpeg_g)
==3402053==    by 0x67EC84: ebml_parse (in ffmpeg/ffmpeg_g)
==3402053==    by 0x67F421: matroska_read_header (in ffmpeg/ffmpeg_g)
==3402053==    by 0x625A1E: avformat_open_input (in ffmpeg/ffmpeg_g)
==3402053==    by 0x3054D4: ifile_open (in ffmpeg/ffmpeg_g)
==3402053==    by 0x31C417: open_files.isra.0 (in ffmpeg/ffmpeg_g)
==3402053==    by 0x31E3F5: ffmpeg_parse_options (in ffmpeg/ffmpeg_g)
==3402053==    by 0x2FCD77: main (in ffmpeg/ffmpeg_g)
==3402053==  Address 0x118dd288 is 0 bytes after a block of size 1,672 alloc'd
==3402053==    at 0x483E0F0: memalign (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==3402053==    by 0x483E212: posix_memalign (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==3402053==    by 0x128A524: av_malloc (in ffmpeg/ffmpeg_g)
==3402053==    by 0x128A6ED: av_mallocz (in ffmpeg/ffmpeg_g)
==3402053==    by 0x625DC4: avformat_open_input (in ffmpeg/ffmpeg_g)
==3402053==    by 0x3054D4: ifile_open (in ffmpeg/ffmpeg_g)
==3402053==    by 0x31C417: open_files.isra.0 (in ffmpeg/ffmpeg_g)
==3402053==    by 0x31E3F5: ffmpeg_parse_options (in ffmpeg/ffmpeg_g)
==3402053==    by 0x2FCD77: main (in ffmpeg/ffmpeg_g)


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20250405/c9784391/attachment.sig>