[FFmpeg-devel] [PATCH] swscale/ppc: disable YUV2RGB AltiVec acceleration

[Michael Niedermayer]

Hi Sean

On Fri, Nov 22, 2024 at 05:31:39PM -0500, Sean McGovern wrote:
> Hi,
> 
> 
> On Tue, Nov 19, 2024, 00:06 Sean McGovern <gseanmcg at gmail.com> wrote:
> 
> > The FATE test 'checkasm-sw_yuv2rgb' currently fails on this platform,
> > in both little- and big-endian configurations.
> >
> > Disable it by default.
> > Add '-DSWS_USE_ALTIVEC_YUV2RGB' to CPPFLAGS to re-enable it.
> > ---
> >  libswscale/ppc/yuv2rgb_altivec.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/libswscale/ppc/yuv2rgb_altivec.c
> > b/libswscale/ppc/yuv2rgb_altivec.c
> > index 9db305f43f..d42b39488e 100644
> > --- a/libswscale/ppc/yuv2rgb_altivec.c
> > +++ b/libswscale/ppc/yuv2rgb_altivec.c
> > @@ -558,6 +558,7 @@ av_cold SwsFunc ff_yuv2rgb_init_ppc(SwsInternal *c)
> >          if ((c->srcH & 0x1) != 0)
> >              return NULL;
> >
> > +#ifdef SWS_USE_ALTIVEC_YUV2RGB
> >          switch (c->dstFormat) {
> >          case AV_PIX_FMT_RGB24:
> >              av_log(c, AV_LOG_WARNING, "ALTIVEC: Color Space RGB24\n");
> > @@ -579,6 +580,7 @@ av_cold SwsFunc ff_yuv2rgb_init_ppc(SwsInternal *c)
> >              return altivec_yuv2_bgra;
> >          default: return NULL;
> >          }
> > +#endif /* SWS_USE_ALTIVEC_YUV2RGB */
> >          break;
> >
> >      case AV_PIX_FMT_UYVY422:
> > --
> > 2.39.5
> >
> 
> Ping.

> 
> Also I have not checked but does this need to be rebased over-top of Nik
> Haas' recent swscale changes?
> (Yes, this is a thinly veiled wish we had a CI application that would just
> tell me this outright on a merge request.)

the patches conflict:

@@@ -555,10 -555,11 +555,17 @@@ av_cold SwsFunc ff_yuv2rgb_init_ppc(Sws
      case AV_PIX_FMT_GRAY8:
      case AV_PIX_FMT_NV12:
      case AV_PIX_FMT_NV21:
 -        if ((c->srcH & 0x1) != 0)
 +        if ((c->opts.src_h & 0x1) != 0)
              return NULL;

++<<<<<<< HEAD
 +        switch (c->opts.dst_format) {
++||||||| constructed merge base
++        switch (c->dstFormat) {
++=======
+ #ifdef SWS_USE_ALTIVEC_YUV2RGB
+         switch (c->dstFormat) {
++>>>>>>> swscale/ppc: disable YUV2RGB AltiVec acceleration
          case AV_PIX_FMT_RGB24:
              av_log(c, AV_LOG_WARNING, "ALTIVEC: Color Space RGB24\n");
              return altivec_yuv2_rgb24;

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The smallest minority on earth is the individual. Those who deny 
individual rights cannot claim to be defenders of minorities. - Ayn Rand
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241124/5cb96a4e/attachment.sig>