[FFmpeg-devel] [PATCH] swscale/ppc: disable YUV2RGB AltiVec acceleration

[Sean McGovern]

Hi,


On Tue, Nov 19, 2024, 00:06 Sean McGovern <gseanmcg at gmail.com> wrote:

> The FATE test 'checkasm-sw_yuv2rgb' currently fails on this platform,
> in both little- and big-endian configurations.
>
> Disable it by default.
> Add '-DSWS_USE_ALTIVEC_YUV2RGB' to CPPFLAGS to re-enable it.
> ---
>  libswscale/ppc/yuv2rgb_altivec.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/libswscale/ppc/yuv2rgb_altivec.c
> b/libswscale/ppc/yuv2rgb_altivec.c
> index 9db305f43f..d42b39488e 100644
> --- a/libswscale/ppc/yuv2rgb_altivec.c
> +++ b/libswscale/ppc/yuv2rgb_altivec.c
> @@ -558,6 +558,7 @@ av_cold SwsFunc ff_yuv2rgb_init_ppc(SwsInternal *c)
>          if ((c->srcH & 0x1) != 0)
>              return NULL;
>
> +#ifdef SWS_USE_ALTIVEC_YUV2RGB
>          switch (c->dstFormat) {
>          case AV_PIX_FMT_RGB24:
>              av_log(c, AV_LOG_WARNING, "ALTIVEC: Color Space RGB24\n");
> @@ -579,6 +580,7 @@ av_cold SwsFunc ff_yuv2rgb_init_ppc(SwsInternal *c)
>              return altivec_yuv2_bgra;
>          default: return NULL;
>          }
> +#endif /* SWS_USE_ALTIVEC_YUV2RGB */
>          break;
>
>      case AV_PIX_FMT_UYVY422:
> --
> 2.39.5
>

Ping.

Also I have not checked but does this need to be rebased over-top of Nik
Haas' recent swscale changes?
(Yes, this is a thinly veiled wish we had a CI application that would just
tell me this outright on a merge request.)

-- Sean McGovern

>