[FFmpeg-devel] [PATCH] avfilter: add sdlvsink for video display

Rémi Denis-Courmont remi at remlab.net
Fri Jun 7 09:45:09 EEST 2024


Hi,

Le 7 juin 2024 06:33:20 GMT+03:00, Shiqi Zhu <hiccupzhu at gmail.com> a écrit :
>> Initialization and render in the same thread is one of the issues. Another
>> issue is SDL render should be run in main thread. Maybe it’s not the
>> duty of this filter to control which thread to be called, but this wouldn’t
>> work with ffmpeg cmd.
>>
>Yes, I agree with your opinion. The control of the filter should be
>left to the application, and the ffmpeg command should only serve the
>purpose of demonstrating functionality.

You can't require running on the main thread. There are no ifs or buts here; libavfilter simply can't require that from the calling application or upper-layer framework and therefore it also can't warrant it to SDL.

SDL is meant to be used by programs, notably games, not middleware thread-agnostic libraries like FFmpeg's libav*. I don't think that there is a point arguing *again*.


More information about the ffmpeg-devel mailing list