[FFmpeg-devel] [PATCH] avformat/Makefile: add iso_writer golomb_tab from shared library dependency

[Peter Ross]

On Wed, Dec 18, 2024 at 05:21:33PM -0300, James Almer wrote:
> On 12/18/2024 5:17 PM, Peter Ross wrote:
> > ---
> >   libavformat/Makefile | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/Makefile b/libavformat/Makefile
> > index dd96bf7ba8..a6935ad244 100644
> > --- a/libavformat/Makefile
> > +++ b/libavformat/Makefile
> > @@ -728,7 +728,7 @@ OBJS-$(CONFIG_LIBZMQ_PROTOCOL)           += libzmq.o
> >   # Objects duplicated from other libraries for shared builds
> >   SHLIBOBJS                                += log2_tab.o to_upper4.o
> > -SHLIBOBJS-$(CONFIG_ISO_MEDIA)            += mpegaudiotabs.o
> > +SHLIBOBJS-$(CONFIG_ISO_WRITER)           += golomb_tab.o mpegaudiotabs.o
> 
> Why are you changing the module? mpegaudiotabs.o should remain for
> CONFIG_ISO_MEDIA, seeing it's used by a demuxer function in isom.c

it should just be:

+SHLIBOBJS-$(CONFIG_ISO_WRITER)           += golomb_tab.o

> LGTM otherwise.

fixed locally. i will push shortly.

also just ran an exhaustive search with `./configure --disable-all --enable-$x=$y`
and found a few similar issues.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241219/63c65258/attachment.sig>