[FFmpeg-devel] [PATCH] avformat/Makefile: add iso_writer golomb_tab from shared library dependency

[James Almer]

On 12/18/2024 5:17 PM, Peter Ross wrote:
> ---
>   libavformat/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/Makefile b/libavformat/Makefile
> index dd96bf7ba8..a6935ad244 100644
> --- a/libavformat/Makefile
> +++ b/libavformat/Makefile
> @@ -728,7 +728,7 @@ OBJS-$(CONFIG_LIBZMQ_PROTOCOL)           += libzmq.o
>   
>   # Objects duplicated from other libraries for shared builds
>   SHLIBOBJS                                += log2_tab.o to_upper4.o
> -SHLIBOBJS-$(CONFIG_ISO_MEDIA)            += mpegaudiotabs.o
> +SHLIBOBJS-$(CONFIG_ISO_WRITER)           += golomb_tab.o mpegaudiotabs.o

Why are you changing the module? mpegaudiotabs.o should remain for 
CONFIG_ISO_MEDIA, seeing it's used by a demuxer function in isom.c

LGTM otherwise.

>   SHLIBOBJS-$(CONFIG_FLV_MUXER)            += mpeg4audio_sample_rates.o
>   SHLIBOBJS-$(CONFIG_HLS_DEMUXER)          += ac3_channel_layout_tab.o
>   SHLIBOBJS-$(CONFIG_IMAGE_JPEGXL_PIPE_DEMUXER)    += jpegxl_parse.o
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20241218/a915a867/attachment.sig>