[FFmpeg-devel] [PATCH] bsf: use standard include paths

[Paul B Mahol]

And the New Dictator have Risen!

On Wed, Apr 10, 2024 at 4:12 PM Andreas Rheinhardt <
andreas.rheinhardt at outlook.com> wrote:

> Andrew Kelley:
> > Removes the special -I flag specified in the avcodec/bsf/ subdirectory.
> >
> > This makes code copy-pastable to other parts of the ffmpeg codebase, as
> > well as simplifying the build script.
>
> If you want to make the code copy-pastable to other parts, you need to
> disallow using the ordinary relative-path header inclusion. And I don't
> see a simplification of the Makefile.
>
> >
> > It also reduces ambiguity, since there are many instances of same-named
> > header files existing in both libavformat/ and libavcodec/
> > subdirectories.
>
> What ambiguity? As said above, said ambiguity emanates from using
> inclusions with relative paths (and from using the same header
> filenames) and not adding an -I for the parent folder for the files in a
> subfolder. (It would be different if we did something nuts like adding
> -Ilibavcodec to the compilation of libavformat files).
>
> - Andreas
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>