[FFmpeg-devel] [PATCH] bsf: use standard include paths

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Wed Apr 10 17:11:45 EEST 2024


Andrew Kelley:
> Removes the special -I flag specified in the avcodec/bsf/ subdirectory.
> 
> This makes code copy-pastable to other parts of the ffmpeg codebase, as
> well as simplifying the build script.

If you want to make the code copy-pastable to other parts, you need to
disallow using the ordinary relative-path header inclusion. And I don't
see a simplification of the Makefile.

> 
> It also reduces ambiguity, since there are many instances of same-named
> header files existing in both libavformat/ and libavcodec/
> subdirectories.

What ambiguity? As said above, said ambiguity emanates from using
inclusions with relative paths (and from using the same header
filenames) and not adding an -I for the parent folder for the files in a
subfolder. (It would be different if we did something nuts like adding
-Ilibavcodec to the compilation of libavformat files).

- Andreas



More information about the ffmpeg-devel mailing list