[FFmpeg-devel] Commit Message Line Wrapping

[Michael Niedermayer]

On Wed, Oct 13, 2021 at 11:46:30AM +0000, Soft Works wrote:
> Hi everybody,
> 
> I have submitted a patch with the following commit message:
> (with the patch being about text column alignment)
> 
> -------------------------
> 
> Before:
> 
> overlay AVOptions:
>   x                 <string>     ..FV....... set the x expression (default "0")
>   y                 <string>     ..FV....... set the y expression (default "0")
>   eof_action        <int>        ..FV....... Action to take when encountering EOF from secondary input  (from 0 to 2) (default repeat)
>      repeat          0            ..FV....... Repeat the previous frame.
>      endall          1            ..FV....... End both streams.
>      pass            2            ..FV....... Pass through the main input.
>   eval              <int>        ..FV....... specify when to evaluate expressions (from 0 to 1) (default frame)
> 
> After:
> 
> overlay AVOptions:
>    x                 <string>     ..FV....... set the x expression (default "0")
>    y                 <string>     ..FV....... set the y expression (default "0")
>    eof_action        <int>        ..FV....... Action to take when encountering EOF from secondary input  (from 0 to 2) (default repeat)
>      repeat          0            ..FV....... Repeat the previous frame.
>      endall          1            ..FV....... End both streams.
>      pass            2            ..FV....... Pass through the main input.
>    eval              <int>        ..FV....... specify when to evaluate expressions (from 0 to 1) (default frame)
> 
> -------------------------
> 
> Now, Patchwork tells: "Please wrap lines in the body of the commit message between 60 and 72 characters".
> When I do this, I get the following result:
> 
> -------------------------
> 
> Before:
> 
> overlay AVOptions:
>   x                 <string>     ..FV....... set the x expression 
> (default "0")
>   y                 <string>     ..FV....... set the y expression 
> (default "0")
>   eof_action        <int>        ..FV....... Action to take when 
> encountering EOF from secondary input  (from 0 to 2) (default 
> repeat)
>      repeat          0            ..FV....... Repeat the previous 
> frame.
>      endall          1            ..FV....... End both streams.
>      pass            2            ..FV....... Pass through the main 
> input.
>   eval              <int>        ..FV....... specify when to 
> evaluate expressions (from 0 to 1) (default frame)
> 
> After:
> a
> overlay AVOptions:
>    x                 <string>     ..FV....... set the x expression 
> (default "0")
>    y                 <string>     ..FV....... set the y expression 
> (default "0")
>    eof_action        <int>        ..FV....... Action to take when 
> encountering EOF from secondary input  (from 0 to 2) (default 
> repeat)
>      repeat          0            ..FV....... Repeat the previous 
> frame.
>      endall          1            ..FV....... End both streams.
>      pass            2            ..FV....... Pass through the main 
> input.
>    eval              <int>        ..FV....... specify when to 
> evaluate expressions (from 0 to 1) (default frame)
> 
> -------------------------
> 
> 
> Now I'm unsure.
> Should I really change the commit message to the above and resubmit?

I think its better to ignore Patchwork in this rare case

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20211013/2e269874/attachment.sig>