[FFmpeg-devel] Commit Message Line Wrapping
Soft Works
softworkz at hotmail.com
Wed Oct 13 14:46:30 EEST 2021
Hi everybody,
I have submitted a patch with the following commit message:
(with the patch being about text column alignment)
-------------------------
Before:
overlay AVOptions:
x <string> ..FV....... set the x expression (default "0")
y <string> ..FV....... set the y expression (default "0")
eof_action <int> ..FV....... Action to take when encountering EOF from secondary input (from 0 to 2) (default repeat)
repeat 0 ..FV....... Repeat the previous frame.
endall 1 ..FV....... End both streams.
pass 2 ..FV....... Pass through the main input.
eval <int> ..FV....... specify when to evaluate expressions (from 0 to 1) (default frame)
After:
overlay AVOptions:
x <string> ..FV....... set the x expression (default "0")
y <string> ..FV....... set the y expression (default "0")
eof_action <int> ..FV....... Action to take when encountering EOF from secondary input (from 0 to 2) (default repeat)
repeat 0 ..FV....... Repeat the previous frame.
endall 1 ..FV....... End both streams.
pass 2 ..FV....... Pass through the main input.
eval <int> ..FV....... specify when to evaluate expressions (from 0 to 1) (default frame)
-------------------------
Now, Patchwork tells: "Please wrap lines in the body of the commit message between 60 and 72 characters".
When I do this, I get the following result:
-------------------------
Before:
overlay AVOptions:
x <string> ..FV....... set the x expression
(default "0")
y <string> ..FV....... set the y expression
(default "0")
eof_action <int> ..FV....... Action to take when
encountering EOF from secondary input (from 0 to 2) (default
repeat)
repeat 0 ..FV....... Repeat the previous
frame.
endall 1 ..FV....... End both streams.
pass 2 ..FV....... Pass through the main
input.
eval <int> ..FV....... specify when to
evaluate expressions (from 0 to 1) (default frame)
After:
a
overlay AVOptions:
x <string> ..FV....... set the x expression
(default "0")
y <string> ..FV....... set the y expression
(default "0")
eof_action <int> ..FV....... Action to take when
encountering EOF from secondary input (from 0 to 2) (default
repeat)
repeat 0 ..FV....... Repeat the previous
frame.
endall 1 ..FV....... End both streams.
pass 2 ..FV....... Pass through the main
input.
eval <int> ..FV....... specify when to
evaluate expressions (from 0 to 1) (default frame)
-------------------------
Now I'm unsure.
Should I really change the commit message to the above and resubmit?
Thanks,
softworkz
More information about the ffmpeg-devel
mailing list