[FFmpeg-devel] [PATCH v2 1/1] fftools/ffprobe: print size of attachment streams (extradata_size)

[Michael Niedermayer]

On Thu, Nov 25, 2021 at 05:42:27PM +0100, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2021-11-25 17:38:59)
> > On Thu, Nov 25, 2021 at 03:05:23AM +0000, Soft Works wrote:
> > > Signed-off-by: softworkz <softworkz at hotmail.com>
> > > ---
> > > v2: As suggested by Marton, I'm always prniting extradata_size now instead of an 'attachment_size' value.
> > > The downside is that a number of tests need to be changed and probably, Patchwork won't get it right again (due to long lines).
> > > 
> > >  doc/ffprobe.xsd                                     | 1 +
> > >  fftools/ffprobe.c                                   | 1 +
> > >  tests/ref/fate/concat-demuxer-extended-lavf-mxf     | 2 +-
> > >  tests/ref/fate/concat-demuxer-extended-lavf-mxf_d10 | 2 +-
> > >  tests/ref/fate/concat-demuxer-simple1-lavf-mxf      | 2 +-
> > >  tests/ref/fate/concat-demuxer-simple1-lavf-mxf_d10  | 2 +-
> > >  tests/ref/fate/concat-demuxer-simple2-lavf-ts       | 2 +-
> > >  tests/ref/fate/flv-demux                            | 4 ++--
> > >  tests/ref/fate/mov-zombie                           | 2 +-
> > >  tests/ref/fate/mxf-probe-d10                        | 1 +
> > >  tests/ref/fate/oggopus-demux                        | 2 +-
> > >  tests/ref/fate/ts-demux                             | 2 +-
> > >  tests/ref/fate/ts-opus-demux                        | 2 +-
> > >  tests/ref/fate/ts-small-demux                       | 2 +-
> > >  14 files changed, 15 insertions(+), 12 deletions(-)
> > 
> > doesnt apply (maybe long line issue)
> > so i cannot test this
> > 
> > Applying: fftools/ffprobe: print size of attachment streams (extradata_size)
> > error: corrupt patch at line 106
> > error: could not build fake ancestor
> > Patch failed at 0001 fftools/ffprobe: print size of attachment streams (extradata_size)
> 
> I've encountered this before, IIRC the problem is in the mailing list
> software that breaks very long lines.
> 
> Properly the ML software should be fixed to not mangle text patches.

what i remember was that the RFC demanded breaking lines, and that somehow
occured in the middle of the mail handling. 
Id assume this must affect many projects but i dont remember seeing an
existing solution

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20211125/524c88fc/attachment.sig>