[FFmpeg-devel] [PATCH v2 1/1] fftools/ffprobe: print size of attachment streams (extradata_size)

Anton Khirnov anton at khirnov.net
Thu Nov 25 18:42:27 EET 2021


Quoting Michael Niedermayer (2021-11-25 17:38:59)
> On Thu, Nov 25, 2021 at 03:05:23AM +0000, Soft Works wrote:
> > Signed-off-by: softworkz <softworkz at hotmail.com>
> > ---
> > v2: As suggested by Marton, I'm always prniting extradata_size now instead of an 'attachment_size' value.
> > The downside is that a number of tests need to be changed and probably, Patchwork won't get it right again (due to long lines).
> > 
> >  doc/ffprobe.xsd                                     | 1 +
> >  fftools/ffprobe.c                                   | 1 +
> >  tests/ref/fate/concat-demuxer-extended-lavf-mxf     | 2 +-
> >  tests/ref/fate/concat-demuxer-extended-lavf-mxf_d10 | 2 +-
> >  tests/ref/fate/concat-demuxer-simple1-lavf-mxf      | 2 +-
> >  tests/ref/fate/concat-demuxer-simple1-lavf-mxf_d10  | 2 +-
> >  tests/ref/fate/concat-demuxer-simple2-lavf-ts       | 2 +-
> >  tests/ref/fate/flv-demux                            | 4 ++--
> >  tests/ref/fate/mov-zombie                           | 2 +-
> >  tests/ref/fate/mxf-probe-d10                        | 1 +
> >  tests/ref/fate/oggopus-demux                        | 2 +-
> >  tests/ref/fate/ts-demux                             | 2 +-
> >  tests/ref/fate/ts-opus-demux                        | 2 +-
> >  tests/ref/fate/ts-small-demux                       | 2 +-
> >  14 files changed, 15 insertions(+), 12 deletions(-)
> 
> doesnt apply (maybe long line issue)
> so i cannot test this
> 
> Applying: fftools/ffprobe: print size of attachment streams (extradata_size)
> error: corrupt patch at line 106
> error: could not build fake ancestor
> Patch failed at 0001 fftools/ffprobe: print size of attachment streams (extradata_size)

I've encountered this before, IIRC the problem is in the mailing list
software that breaks very long lines.

Properly the ML software should be fixed to not mangle text patches.

A workaround is to send such patches as something other than text/plain

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list