[FFmpeg-devel] Encode user data unregistered SEI (H.264/H.265)

[Marton Balint]

On Tue, 11 May 2021, Brad Hards wrote:

> On Saturday, 1 May 2021 12:23:00 PM AEST Brad Hards wrote:
>> MISB ST 0604 and ST 2101 require user data unregistered SEI messages
>> (precision timestamps and sensor identifiers) to be included. That
>> currently isn't supported. This series adds encoding for libx264,
>> libx265, hevc_nvenc and h264_nvenc.
>>
>> v2 removes the API addition, modifies nvenc to use a dynamic array,
>> and corrects formatting.
> Any comments on v2?

As far as I see it is consistently missing allocation checks for 
realloc_array all over the place.

Is it realistic that more than e.g. 16 SEI data is needed? If not, then 
maybe static allocation for SEI data and limiting the number to 16 
or so should be simpler.

Regards,
Marton