[FFmpeg-devel] [RFC PATCH] avformat/dashdec: Improve implementation

[Steven Liu]

> 在 2021年3月29日，04:50，Derek Buitenhuis <derek.buitenhuis at gmail.com> 写道：
> 
> On 28/03/2021 21:05, Carl Eugen Hoyos wrote:
>> The patch clearly mentions that it is a "rework".
>> If the maintainer likes it, it would be nice if it can be simplified but
>> this may not be possible.
> 
> Of course it's /possible/. People have been splitting rewrites/refactors into
> these since forever; FFmpeg's history is full of them. 
> 
> I'm not going to argue if Steven is fine with it, but it's certainly possible.
Hi Derek,

I think your opinion fine.
I focused on make compilation pass first.
Your comments about “ These should be separate, testable, atomic commits. “, should be respected,
I think FFmpeg should make patch rule a little bit more detail for how to separate,
then contributors will get a reference for that.

Totally agree “ These should be separate, testable, atomic commits. “ base on compilation pass.
> 
> I hope I never come across this in a git bisect or blame...
> 
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

Thanks
Steven