[FFmpeg-devel] [PATCH 1/9 v3] avutil/buffer: change public function and struct size parameter types to size_t
James Almer
jamrial at gmail.com
Wed Mar 10 23:12:55 EET 2021
On 3/10/2021 4:38 PM, Michael Niedermayer wrote:
> On Sat, Mar 06, 2021 at 04:42:35PM -0300, James Almer wrote:
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> Changes since v2 is the addition of the buffer_size_t typedef to reduce the
>> amount of ifdeffery required to adapt our code.
>>
>> doc/APIchanges | 4 ++++
>> libavutil/buffer.c | 14 +++++++-------
>> libavutil/buffer.h | 32 ++++++++++++++++++++++++++++++++
>> libavutil/buffer_internal.h | 8 ++++----
>> libavutil/internal.h | 7 +++++++
>> libavutil/version.h | 5 ++++-
>> 6 files changed, 58 insertions(+), 12 deletions(-)
>
> The patchset prior to the bump LGTM
> the patchset after the bump (thus enabled size_t) is probably ok but
> i did not review this for downstream effects which could introduce bugs
> when theres any code that expected the variables to be int
That's what 2+ years of advanced warning are for. Same as we did with
the Crypto modules that will be switching to size_t in the upcoming bump.
>
> code prior bump tested, code post bump not tested
>
> Thanks
>
> [...]
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>
More information about the ffmpeg-devel
mailing list