[FFmpeg-devel] [PATCH 1/9 v3] avutil/buffer: change public function and struct size parameter types to size_t

Michael Niedermayer michael at niedermayer.cc
Wed Mar 10 21:38:14 EET 2021


On Sat, Mar 06, 2021 at 04:42:35PM -0300, James Almer wrote:
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> Changes since v2 is the addition of the buffer_size_t typedef to reduce the
> amount of ifdeffery required to adapt our code.
> 
>  doc/APIchanges              |  4 ++++
>  libavutil/buffer.c          | 14 +++++++-------
>  libavutil/buffer.h          | 32 ++++++++++++++++++++++++++++++++
>  libavutil/buffer_internal.h |  8 ++++----
>  libavutil/internal.h        |  7 +++++++
>  libavutil/version.h         |  5 ++++-
>  6 files changed, 58 insertions(+), 12 deletions(-)

The patchset prior to the bump LGTM
the patchset after the bump (thus enabled size_t) is probably ok but
i did not review this for downstream effects which could introduce bugs
when theres any code that expected the variables to be int

code prior bump tested, code post bump not tested

Thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210310/fa47578c/attachment.sig>


More information about the ffmpeg-devel mailing list