[FFmpeg-devel] [PATCH 2/3] avformat/sbgdec: Check opt_duration and start for overflow

Nicolas George george at nsup.org
Sun Jun 27 21:22:12 EEST 2021


James Almer (12021-06-25):
> Afaics, it checks the very first character to be < '0' || > '9' for both
> hours and minutes, so strtol() is not going to see a '-'.
> Is there supposed to be one for seconds in valid files? If not, the same
> check could be done and ensure no negative value is parsed.

No, valid files cannot have negative times.

Also, I think with the time that adding this format was a misguided
idea. I suspect nobody uses it. We could just remove it.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210627/9b4b7419/attachment.sig>


More information about the ffmpeg-devel mailing list