[FFmpeg-devel] [PATCH] lavu/cpu: Use av_cpu_ prefix

[James Almer]

On 7/19/2021 6:58 PM, Andreas Rheinhardt wrote:
> Thilo Borgmann:
>> Am 19.07.21 um 23:20 schrieb James Almer:
>>> On 7/19/2021 6:19 PM, Andreas Rheinhardt wrote:
>>>> Thilo Borgmann:
>>>>> Hi,
>>>>>
>>>>> $subject for the new force cpu count function.
>>>>>
>>>>> Thanks,
>>>>> Thilo
>>>>>
>>>>
>>>> I just wanted to complain that you did not modify APIchanges as well;
>>>> but then I noticed that there is no entry there for this new function.
>>>> But there should be.
>>>
>>> No version bump either, so this patch should definitely do both things.
>>
>> Ok, does the attached look better?
>>
> 
> Missing version bump.
> 
>> Also, is the commit hash meant be added in a separate commit later to doc/APIchanges?
>>
> 
> The commit hash is meant to be the hash of the commit that
> added/removed/deprecated said API. In this case it is either 87951dcbe7
> or the hash of your fixup commit. In the latter case (and also in the

The hash of this fixup should be used, since it will both be linked to 
the version bump, and actually feature the new av_cpu namespaced symbol. 
So the xxxx placeholder is good.

> ordinary case where a new API is added in one commit without a later
> fixup) said hash is not known in advance, therefore the placeholder
> xxxxxxxxxx is used. These placeholders are replaced by the real hashes
> before every release.
> 
> - Andreas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>