[FFmpeg-devel] [PATCH] lavu/cpu: Use av_cpu_ prefix

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Tue Jul 20 00:58:05 EEST 2021


Thilo Borgmann:
> Am 19.07.21 um 23:20 schrieb James Almer:
>> On 7/19/2021 6:19 PM, Andreas Rheinhardt wrote:
>>> Thilo Borgmann:
>>>> Hi,
>>>>
>>>> $subject for the new force cpu count function.
>>>>
>>>> Thanks,
>>>> Thilo
>>>>
>>>
>>> I just wanted to complain that you did not modify APIchanges as well;
>>> but then I noticed that there is no entry there for this new function.
>>> But there should be.
>>
>> No version bump either, so this patch should definitely do both things.
> 
> Ok, does the attached look better?
> 

Missing version bump.

> Also, is the commit hash meant be added in a separate commit later to doc/APIchanges?
> 

The commit hash is meant to be the hash of the commit that
added/removed/deprecated said API. In this case it is either 87951dcbe7
or the hash of your fixup commit. In the latter case (and also in the
ordinary case where a new API is added in one commit without a later
fixup) said hash is not known in advance, therefore the placeholder
xxxxxxxxxx is used. These placeholders are replaced by the real hashes
before every release.

- Andreas


More information about the ffmpeg-devel mailing list