[FFmpeg-devel] [PATCH 2/6] avcodec: add h266 codec id and profiles

[Mark Thompson]

On 22/12/2020 10:37, Nuo Mi wrote:
> Hi James,
> thanks for the review.
> 
> On Mon, Dec 21, 2020 at 11:14 PM James Almer <jamrial at gmail.com> wrote:
> 
>> On 12/21/2020 3:07 AM, Nuo Mi wrote:
>>> ---
>>>    libavcodec/avcodec.h    | 2 ++
>>>    libavcodec/codec_desc.c | 8 ++++++++
>>>    libavcodec/codec_id.h   | 2 ++
>>>    libavcodec/profiles.c   | 5 +++++
>>>    libavcodec/profiles.h   | 1 +
>>>    5 files changed, 18 insertions(+)
>>>
>>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>>> index 1d3099d50a..f7ea4d5849 100644
>>> --- a/libavcodec/avcodec.h
>>> +++ b/libavcodec/avcodec.h
>>> @@ -1961,6 +1961,8 @@ typedef struct AVCodecContext {
>>>    #define FF_PROFILE_HEVC_MAIN_STILL_PICTURE          3
>>>    #define FF_PROFILE_HEVC_REXT                        4
>>>
>>> +#define FF_PROFILE_H266_MAIN_10                      1
>>
>> We should decide first what we are going to use, if VVC or h266.
>>
>> My suggestion was to use VVC for decoder, parser, demuxer and public
>> defines, which is what's exposed to the user, and h266 for CBS, which
>> makes things simpler to implement and is proper consider it's written
>> using the ITU spec.
>>
> Sorry for missed this. But seems mark and you have a different suggestion.
> Could you align with him and other maintainers?

I have a preference for the ITU names, but in the end it's not very strong.

Please do go with the suggestion from James to use the VVC name in the external things, and h266 for cbs internals.

Thanks,

- Mark