[FFmpeg-devel] [PATCH 2/6] avcodec: add h266 codec id and profiles

[Nuo Mi]

On Sat, Jan 2, 2021 at 10:06 AM Nuo Mi <nuomi2021 at gmail.com> wrote:

> Hi Mark & all,
> Happy new year!
> I have implemented the h266 metadata bsf. For all vvdec decodable clips,
> the metadata pass-through mode can get a bit matched result.
> Could you align with James about the name convention, so I can send the
> second patchset?
>
> BTW: could you share the hevc aud adding command line?
> I tried "ffmpeg -i input.265  -c:v copy -bsf h266_metadata -aud insert
> output.265", but the output.265 has no aud.
>
> thanks
>
>
> On Sat, Dec 26, 2020 at 9:37 AM Nuo Mi <nuomi2021 at gmail.com> wrote:
>
>>
>>
>> On Tue, Dec 22, 2020 at 6:37 PM Nuo Mi <nuomi2021 at gmail.com> wrote:
>>
>>>
>>> Hi James,
>>> thanks for the review.
>>>
>>> On Mon, Dec 21, 2020 at 11:14 PM James Almer <jamrial at gmail.com> wrote:
>>>
>>>> On 12/21/2020 3:07 AM, Nuo Mi wrote:
>>>> > ---
>>>> >   libavcodec/avcodec.h    | 2 ++
>>>> >   libavcodec/codec_desc.c | 8 ++++++++
>>>> >   libavcodec/codec_id.h   | 2 ++
>>>> >   libavcodec/profiles.c   | 5 +++++
>>>> >   libavcodec/profiles.h   | 1 +
>>>> >   5 files changed, 18 insertions(+)
>>>> >
>>>> > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>>>> > index 1d3099d50a..f7ea4d5849 100644
>>>> > --- a/libavcodec/avcodec.h
>>>> > +++ b/libavcodec/avcodec.h
>>>> > @@ -1961,6 +1961,8 @@ typedef struct AVCodecContext {
>>>> >   #define FF_PROFILE_HEVC_MAIN_STILL_PICTURE          3
>>>> >   #define FF_PROFILE_HEVC_REXT                        4
>>>> >
>>>> > +#define FF_PROFILE_H266_MAIN_10                      1
>>>>
>>>> We should decide first what we are going to use, if VVC or h266.
>>>>
>>>> My suggestion was to use VVC for decoder, parser, demuxer and public
>>>> defines, which is what's exposed to the user, and h266 for CBS, which
>>>> makes things simpler to implement and is proper consider it's written
>>>> using the ITU spec.
>>>>
>>> Sorry for missed this. But seems mark and you have a different
>>> suggestion.  Could you align with him and other maintainers?
>>> I can continue to address other issues. It's not too later to change
>>> this before I checked the patch set.
>>>
>> Hi Mark,
>> Most of the issue are addressed.  I will send the second reversion of
>> this patchset.
>> Are you ok with James's suggestion?
>>
>
Hi Mark,
ping.