[FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

Mohammad Izadi izadi at google.com
Mon Nov 23 23:27:52 EET 2020


Thanks,
Mohammad


On Fri, Nov 20, 2020 at 5:44 AM Anton Khirnov <anton at khirnov.net> wrote:

> Quoting Mohammad Izadi (2020-11-20 04:57:11)
> > From: Mohammad Izadi <moh.izadi at gmail.com>
> >
> > HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs
> to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred
> to side data packet to be used or passed through.
> > ---
> > The fate test file can be found here:
> https://drive.google.com/file/d/1vcT0ohzpoyVFcxQN32jKIhUrBaBwZweT/view?usp=sharing
> > The video file needs to be copied to fate-suite/mov/
>
> >  configure                                     |   1 +
> >  fftools/ffprobe.c                             | 106 +++++++++
> >  libavcodec/Makefile                           |   3 +
> >  libavcodec/avpacket.c                         |   1 +
> >  libavcodec/decode.c                           |   1 +
> >  libavcodec/dynamic_hdr10_plus.c               | 223 ++++++++++++++++++
> >  .../dynamic_hdr10_plus.h                      |  22 +-
> >  libavcodec/hevc_sei.c                         |  62 ++++-
> >  libavcodec/hevc_sei.h                         |   5 +
> >  libavcodec/hevcdec.c                          |  18 ++
> >  libavcodec/packet.h                           |   8 +
> >  libavcodec/version.h                          |   2 +-
> >  libavfilter/vf_showinfo.c                     | 106 ++++++++-
> >  libavutil/Makefile                            |   2 -
> >  libavutil/hdr_dynamic_metadata.c              |  47 ----
> >  tests/fate/mov.mak                            |   3 +
> >  tests/ref/fate/mov-hdr10-plus-metadata        |  90 +++++++
> >  17 files changed, 629 insertions(+), 71 deletions(-)
> >  create mode 100644 libavcodec/dynamic_hdr10_plus.c
> >  rename libavutil/hdr_dynamic_metadata.h =>
> libavcodec/dynamic_hdr10_plus.h (95%)
>
> You cannot move a public header like that, it breaks API.
>
Right reverted the change in the following patch.

> Also, the patch does way too many things at once, it should be split.

Some changes are asked to be added by reviewers just for being able to test
it. This CL has been hanging for a long time. I think Vittorio and Ian can
help on this to proceed with this CL.

>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list