[FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC.

[Anton Khirnov]

Quoting Mohammad Izadi (2020-11-20 04:57:11)
> From: Mohammad Izadi <moh.izadi at gmail.com>
> 
> HDR10+ is dynamic metadata (A/341 Amendment - SMPTE2094-40) that needs to be decoded from ITU-T T.35 in HEVC bitstream. The HDR10+ is transferred to side data packet to be used or passed through.
> ---
> The fate test file can be found here: https://drive.google.com/file/d/1vcT0ohzpoyVFcxQN32jKIhUrBaBwZweT/view?usp=sharing
> The video file needs to be copied to fate-suite/mov/                                                           
>  configure                                     |   1 +
>  fftools/ffprobe.c                             | 106 +++++++++
>  libavcodec/Makefile                           |   3 +
>  libavcodec/avpacket.c                         |   1 +
>  libavcodec/decode.c                           |   1 +
>  libavcodec/dynamic_hdr10_plus.c               | 223 ++++++++++++++++++
>  .../dynamic_hdr10_plus.h                      |  22 +-
>  libavcodec/hevc_sei.c                         |  62 ++++-
>  libavcodec/hevc_sei.h                         |   5 +
>  libavcodec/hevcdec.c                          |  18 ++
>  libavcodec/packet.h                           |   8 +
>  libavcodec/version.h                          |   2 +-
>  libavfilter/vf_showinfo.c                     | 106 ++++++++-
>  libavutil/Makefile                            |   2 -
>  libavutil/hdr_dynamic_metadata.c              |  47 ----
>  tests/fate/mov.mak                            |   3 +
>  tests/ref/fate/mov-hdr10-plus-metadata        |  90 +++++++
>  17 files changed, 629 insertions(+), 71 deletions(-)
>  create mode 100644 libavcodec/dynamic_hdr10_plus.c
>  rename libavutil/hdr_dynamic_metadata.h => libavcodec/dynamic_hdr10_plus.h (95%)

You cannot move a public header like that, it breaks API.
Also, the patch does way too many things at once, it should be split.

-- 
Anton Khirnov