[FFmpeg-devel] [PATCH 4/5] avformat/rmdec: remove unneeded memset() on packet allocation

[Michael Niedermayer]

On Mon, Nov 02, 2020 at 01:47:25AM +0100, Andreas Rheinhardt wrote:
> Michael Niedermayer:
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavformat/rmdec.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c
> > index 9e954108f9..6a89143bc5 100644
> > --- a/libavformat/rmdec.c
> > +++ b/libavformat/rmdec.c
> > @@ -817,7 +817,6 @@ static int rm_assemble_video_frame(AVFormatContext *s, AVIOContext *pb,
> >          av_packet_unref(&vst->pkt); //FIXME this should be output.
> >          if ((ret = av_new_packet(&vst->pkt, vst->videobufsize)) < 0)
> >              return ret;
> > -        memset(vst->pkt.data, 0, vst->pkt.size);
> >          vst->videobufpos = 8*vst->slices + 1;
> >          vst->cur_slice = 0;
> >          vst->curpic_num = pic_num;
> > 
> Sure that this does not lead to uninitialized padding? Maybe use
> av_shrink_packet() in line 852 instead of directly setting the size.

hmm, av_shrink_packet() is a good idea either way so ill use that

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The smallest minority on earth is the individual. Those who deny 
individual rights cannot claim to be defenders of minorities. - Ayn Rand
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20201104/f6b8dac4/attachment.sig>