[FFmpeg-devel] [PATCH 4/5] avformat/rmdec: remove unneeded memset() on packet allocation

[Andreas Rheinhardt]

Michael Niedermayer:
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavformat/rmdec.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c
> index 9e954108f9..6a89143bc5 100644
> --- a/libavformat/rmdec.c
> +++ b/libavformat/rmdec.c
> @@ -817,7 +817,6 @@ static int rm_assemble_video_frame(AVFormatContext *s, AVIOContext *pb,
>          av_packet_unref(&vst->pkt); //FIXME this should be output.
>          if ((ret = av_new_packet(&vst->pkt, vst->videobufsize)) < 0)
>              return ret;
> -        memset(vst->pkt.data, 0, vst->pkt.size);
>          vst->videobufpos = 8*vst->slices + 1;
>          vst->cur_slice = 0;
>          vst->curpic_num = pic_num;
> 
Sure that this does not lead to uninitialized padding? Maybe use
av_shrink_packet() in line 852 instead of directly setting the size.

- Andreas