[FFmpeg-devel] [PATCH v1] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

Jan Ekström jeebjp at gmail.com
Fri Mar 20 18:24:37 EET 2020


On Fri, Mar 20, 2020 at 6:12 PM Nicolas George <george at nsup.org> wrote:
>
> Jan Ekström (12020-03-20):
> > I do wonder if this is just a case of people forgetting to set the
> > flag for the relevant packets in the relevant modules?
> >
> > I'm not sure if all API users should be forced to handle this
> > separately. If the packets are decode'able by themselves, they should
> > be marked as such.
>
> I had the same idea, and I checked: the problem is that the subtitle
> encoding API returns just a buffer of data, not a packet. With that
> crappy API, this change is the best we can do.
>

Just as I noticed that myself in ffmpeg.c :).

In that case, yes... Until the encoding API pushes out AVPackets we
can't help too much with this :/ . Consider my initial comment moot.

Jan


More information about the ffmpeg-devel mailing list