[FFmpeg-devel] [PATCH v1] fftools/ffmpeg: set AV_PKT_FLAG_KEY for the subtitle packet

Nicolas George george at nsup.org
Fri Mar 20 18:12:27 EET 2020


Jan Ekström (12020-03-20):
> I do wonder if this is just a case of people forgetting to set the
> flag for the relevant packets in the relevant modules?
> 
> I'm not sure if all API users should be forced to handle this
> separately. If the packets are decode'able by themselves, they should
> be marked as such.

I had the same idea, and I checked: the problem is that the subtitle
encoding API returns just a buffer of data, not a packet. With that
crappy API, this change is the best we can do.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200320/3f780e27/attachment.sig>


More information about the ffmpeg-devel mailing list