[FFmpeg-devel] [PATCH] avformat/dashdec: Don't allocate and leak strings that are never used

Nicolas George george at nsup.org
Mon Mar 16 15:42:04 EET 2020


Steven Liu (12020-03-16):
> I think you can rewrite a dashdec if you have interested in it, there
> have lots of bug in it, ok?
> I don’t think just remove some code for it is a good idea, if you want
> to do some thing for it, you can make it complete, not just remove
> some code.

This code is bad: it stores values that are not needed. It should have
never gone in in the first place.

Write code that works, and it will be reviewed. Feel free to ping me
about it.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200316/1761400d/attachment.sig>


More information about the ffmpeg-devel mailing list