[FFmpeg-devel] [PATCH] avformat/dashdec: Don't allocate and leak strings that are never used

[Steven Liu]

> 2020年3月16日 下午9:32，Nicolas George <george at nsup.org> 写道：
> 
> Steven Liu (12020-03-16):
>> Let me do it now, don’t remove the code, ok?
>> Keep the code now or add xmlFree them.
> 
> There is a leak right now, and adding the xmlFree() is more work than
> reverting.
> 
> Also, most of these attributes do not belong as string in the context,
> they belong in local variable to get parsed immediately. I suggest you
> make a helper function to parse integer attributes.
> 
> Reverting is the way to go.
> 
I think you can rewrite a dashdec if you have interested in it, there have lots of bug in it, ok?
I don’t think just remove some code for it is a good idea, if you want to do some thing for it, you can make it complete, not just remove some code.

> Regards,
> 
> -- 
>  Nicolas George