[FFmpeg-devel] [PATCH] avformat/dashdec: Don't allocate and leak strings that are never used

[Nicolas George]

Steven Liu (12020-03-16):
> Let me do it now, don’t remove the code, ok?
> Keep the code now or add xmlFree them.

There is a leak right now, and adding the xmlFree() is more work than
reverting.

Also, most of these attributes do not belong as string in the context,
they belong in local variable to get parsed immediately. I suggest you
make a helper function to parse integer attributes.

Reverting is the way to go.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200316/f79dd5ef/attachment.sig>