[FFmpeg-devel] [Patch] vf_edgedetect: properly implement double_threshold()

Moritz Barsnick barsnick at gmx.net
Tue Jun 23 11:49:35 EEST 2020


On Mon, Jun 22, 2020 at 14:24:19 +0200, Valery Kot wrote:
> On Mon, Jun 22, 2020 at 12:54 PM Moritz Barsnick <barsnick at gmx.net> wrote:
> > NOT of a logical OR can be inverted, so this *may* be more readable as:
> >                if ((i && i != w - 1 && j && j != h - 1) &&
> Indeed, those three are equivalent. Complex logical conditions can be
> written in different ways. I chose mine to minimize change, assuming
> that there was just a typo in original algo implementation.

No problem, I agree a one-byte change maybe more acceptable.

Moritz


More information about the ffmpeg-devel mailing list